Having joined Sheffield Wednesday at just 18 years old he would help Wednesday get to a Cup Final in 1965. He scored in the final to put his team 2-0 up but they would eventually lose to an excellent Everton side 3-0.

Not long after the final David would be involved in a serious car accident that would almost cost him his career. His form and the goals tally dipped significantly and eventually he was allowed to leave to Newcastle United in a swap deal that saw Jackie Sinclair go the other way.

His time at the Magpies was fairly uninspiring however and the following season he was again involved in a player swap deal, this time one that saw John Tudor come the other way from Sheffield United.